plenum

0 Tags

1.4 MiB

Author	SHA1	Message	Date
Lasse Server	291dcebcb8	Replace hardcoded slice(6) with slice("speeches/".length) The magic number 6 is the length of the literal "speeches/" prefix these four call sites strip off an ArangoDB-style id — spelling it out makes that relationship explicit and survives a future rename of the prefix without a silent off-by-N bug. Also swap response.statusText for response.status in fetchTalk's error message: statusText is frequently empty (HTTP/2 drops the reason phrase), so the numeric code is the more reliable thing to show. This mirrors a fix already made directly on rixdagen-prod's production branch (commit 9a87111) that hadn't been brought upstream yet.	5 days ago
Lasse Server	7ea92c9366	Stream the final chat answer instead of one blocking blob packages/llm/client.py:_read_stream yielded token-by-token deltas but was dead code — nothing called generate(stream=True). The chat tool loop always blocked on the final answer generation, so a ~40s answer arrived as a single SSE event and read as a hang, even though the "card stack" already streamed tool-selection progress. The final answer is structurally just whichever tool-loop iteration returns content with no tool_calls — there's no way to know in advance which iteration that'll be, and a turn can carry short narration before a tool call in the very same response. So streaming has to be speculative: - packages/llm/client.py: _read_stream becomes StreamAccumulator, which both streams live (thinking/content/tool_call) deltas and reconstructs a full ChatCompletionMessage (content, tool_calls, reasoning_content) once the stream ends. Tool-call argument fragments are accumulated by index, same pattern every OpenAI-compatible streaming client needs. Downstream tool execution code needed zero changes because of this — it just consumes the reconstructed message instead of the SDK's blocking return value. Also hardened <think>/</think> detection against a tag split across chunk boundaries (was a per-chunk substring check; now a carry-over buffer) — latent before since nothing exercised streaming for real. - backend/services/streaming_answer.py (new): AnswerStreamFilter holds buffered content back until it's implausible to still be one-line narration (this codebase already caps narration at 150 chars elsewhere), and separately holds back any trailing bracket run that could still grow into a [src:ID]/[[src:ID]] marker — citation validity isn't known until parse_and_renumber_citations runs on the complete text, so a raw marker, hallucinated or not, must never reach the client even for a frame. run_streaming_iteration drives one tool-loop iteration through this filter and emits "answer_delta" events; if a tool_call shows up after content already cleared the gate (narration grew unusually long before the model pivoted), it emits one "answer_delta_retract" so the UI doesn't strand a stale preview. - backend/services/chat.py, mp_chat.py: thread an explicit stream_answer flag through to _run_tool_loop's single generate() call site, rather than inferring streaming from event_callback being non-None — eval logging's ConversationRecorder.wrap() always returns a non-None callable, even for the plain blocking /api/chat endpoint, so that inference would have been wrong. Only stream_chat_response (the two SSE routes) sets it; /api/chat is untouched. - Frontend: both SSE consumers (ChatPanel.tsx's card stack, MpChatPanel.tsx's simpler turn list) grow "answer_delta"/"answer_delta_retract" handling. The live preview renders as plain, React-escaped text (no dangerouslySetInnerHTML, no markdown parsing mid-stream — that's a one-shot full-document transform, unsafe on partial input) and is fully replaced by the authoritative, citation-renumbered/person-linked/ language-polished HTML once the terminal "answer" event lands. Both event types were previously-unhandled and silently ignored, so the backend and frontend halves are independently safe to deploy. Added tests/test_llm_client_stream.py and tests/test_streaming_answer.py covering the reconstruction (content, tool-call fragment accumulation, split <think> tags, truncated-stream handling) and the filter (gate timing, citation-marker safety across chunk boundaries, the retract path, error propagation). 5 pre-existing failures in test_prompts_golden.py/ test_provenance.py are unrelated (reproduce identically on main).	5 days ago
Lasse Edfast	81d5ca24c1	Make the theme configurable; add a doctor and an assistant setup guide A fork for Hungary would have looked Swedish. Only party colours were configurable — the warm paper, the institutional blue and the Garamond serif were hardcoded, and that palette was drawn from riksdagen.se deliberately. Nothing said so anywhere. A `theme:` block now sets those as CSS custom properties at runtime, the same mechanism party colours already used, so no stylesheet needs editing. README and PORTING.md both say plainly that the default is not neutral. scripts/doctor.py reports what a machine can and cannot do: Python and dependencies, PostgreSQL with its extensions and text-search setting, schema and row counts, the chat endpoint, whether that model can actually call tools, the embedding dimension against the configured one, GPU, sudo, and which ports are free. It changes nothing and exits non-zero on failures so a script can gate on it. Tool calling is checked separately because a model can converse perfectly and still never call a tool, which here means confident answers with no sources. docs/ASSISTANT-SETUP.md is a prompt plus the interview an assistant should run: ask the doctor before asking the user, one section at a time, always recommend a default, never invent a parliament's colours or data URL, and verify each stage with real output rather than an exit code. Verified against the live deployment: 26 checks OK, no failures.	1 week ago
Lasse Edfast	bad2ad89e3	Refuse writes from model-authored SQL; finish the tool rename database_query passed model-written SQL straight to a connection that commits. The corpus reaches the model's context, and in a parliament anyone able to speak can get text into the corpus, so that SQL has to be treated as untrusted input. Two layers now apply. Statements must begin with SELECT or WITH, and multi-statement payloads are rejected — that is how a write gets smuggled in behind a leading SELECT. Then the query runs inside SET TRANSACTION READ ONLY, so PostgreSQL rejects writes itself even if the first check is wrong. Verified both independently: five attack shapes refused by the guard, and INSERT/DROP still refused when the guard is bypassed entirely and the database layer is called directly. share_insight gets the same treatment. It re-executes SQL stored in saved conversations, which is no more trustworthy than freshly generated SQL. Neither layer replaces running against a SELECT-only role, and SECURITY.md still says so — it now describes what the application does rather than what it fails to do. Tool rename completed as a clean break, no aliases, since there are three users and six sessions to preserve: arango_search -> search_speeches (it has queried Postgres since the Arango migration and the name was pure debt), search_motions -> search_documents, fetch_motion -> fetch_document. Also renamed fetch_documents -> fetch_speeches. It fetches speeches despite the name, and sitting next to the new fetch_document it was a trap the model would fall into. Note for anyone with an MCP client configured against the old names: riksdagen_mcp exposes these, so the names it advertises have changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	1 week ago
Lasse Edfast	80771ff4aa	Rename the schema and code from Swedish to English talks -> speeches ("talks" reads as conference talks to everyone outside this project), motions -> documents with a new doc_type column so bills, written questions and committee reports can share the table later, and 79 columns from anforandetext -> text, intressent_id -> person_id, valkrets -> constituency, lydelse -> text, and so on. _postgres/rename_map.py is the single source of truth. The migration, its rollback, and the code rewrite are all derived from it, so they cannot drift apart. Hand- writing a rollback is how you end up with one that fails halfway through. Two identifiers could not be renamed mechanically and were done by reading the queries: dok_id means the protocol document in talks but the primary key in motions, and year stays a calendar year in speeches while becoming session_year in documents. The latter is aliased in SQL so the JSON field stays `year` and the frontend contract is unchanged. Values are never translated. Bifall and Avslag stay as published; parliament.yaml glosses them. A research tool must not silently rewrite the record. The migration is guarded by an existence check, so the same file is a no-op on a fresh database and does the work on an existing one — one schema definition in the world. ALTER TABLE ... RENAME is catalog-only, so the millions of HNSW-indexed vectors are untouched. The trigger functions are recreated explicitly, because plpgsql bodies are stored as opaque text and do not follow renames: they would have compiled fine and then failed at the next INSERT. They now read the text-search config from a database setting rather than hardcoding 'swedish'. Verified: migration round-trips to a byte-identical schema across columns, indexes and triggers; re-running is a no-op; triggers repopulate search_vector with working Swedish stemming on INSERT and UPDATE; and the renamed code runs real searches against a migrated database holding 5,000 rows of production data, with plain, prefix and exclusion syntax all working. Frontend type errors went from 9 to 7 — the rename fixed two and introduced none. Not yet done, and tracked: legacy compatibility views, the shim for SQL replayed from saved snapshots, tool-name aliases, and updating docs to the new names. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	1 week ago
Lasse Edfast	0be70f9307	Move country-specific values into parliament.yaml Everything that made this Sweden-only in code now lives in one configuration file: party list and colours, chamber activity types, the Postgres text-search dictionary, the party-code pattern used to verify attributions, identifier shapes, source URLs, the person-photo URL template, embedding model and dimension, and the site copy. info.py is deleted. Its party_colors_lighten table is gone too — the tint is now computed from the party colour, so there is no second palette to keep in sync. Its dead select_columns and css strings go with it. The stylesheet no longer carries per-party rules. It had --party-M through --party-NYD plus twenty [data-party="..."] selectors, which no amount of configuration could adapt: CSS cannot read a dict. App.tsx now publishes the configured palette as custom properties from /api/meta, and one color-mix rule covers every party in any country. The author's email and Twitter handle are out of the source entirely. Explainer copy moved to content/sv/*.md, and contact details come from `site.contact`, which upstream ships empty for a deployment to fill in via its own PARLIAMENT_CONFIG. Two startup assertions added, both for failures that are otherwise silent: a text-search config mismatch returns near-zero rows with no error, and a vector column that disagrees with embeddings.dimension fails deep inside pgvector with a message that never mentions configuration. Verified: five searches spanning phrase, exclusion and prefix syntax — exercising all three tsquery builders that changed — return byte-identical payloads against production, with differing hit counts and first hits proving the queries really differ. Frontend builds, and tsc reports the same 9 pre-existing errors as before, none new. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	1 week ago
Lasse Edfast	09c1b3d79c	Initial import from rixdagen Seeded via an explicit allow-list (see /home/lasse/plenum-seed.sh) rather than by deleting files from a copy, so nothing sensitive can survive by omission. Excluded: WireGuard backup + client config, the plaintext DB password in admin.py, Arango credentials in scripts/notes.md, .claude/settings.json, a 113 MB log, providers.yaml (private endpoint), the Arango/ChromaDB-era scripts, the duplicated claude-design-system frontend copy, and assorted screenshots and one-off planning docs. 297 tracked files / 49 MB of history -> 161 files / 2.1 MB. Recovered 14 database migrations that the old .gitignore's `*.sql` rule had been hiding from version control. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	1 week ago

7 Commits (291dcebcb8d5e3f1d9ba034b016fa0b42d018760)