plenum

30 Commits

1 Branch

0 Tags

1.4 MiB

Commit Graph

Author	SHA1	Message	Date
Lasse Edfast	80771ff4aa	Rename the schema and code from Swedish to English talks -> speeches ("talks" reads as conference talks to everyone outside this project), motions -> documents with a new doc_type column so bills, written questions and committee reports can share the table later, and 79 columns from anforandetext -> text, intressent_id -> person_id, valkrets -> constituency, lydelse -> text, and so on. _postgres/rename_map.py is the single source of truth. The migration, its rollback, and the code rewrite are all derived from it, so they cannot drift apart. Hand- writing a rollback is how you end up with one that fails halfway through. Two identifiers could not be renamed mechanically and were done by reading the queries: dok_id means the protocol document in talks but the primary key in motions, and year stays a calendar year in speeches while becoming session_year in documents. The latter is aliased in SQL so the JSON field stays `year` and the frontend contract is unchanged. Values are never translated. Bifall and Avslag stay as published; parliament.yaml glosses them. A research tool must not silently rewrite the record. The migration is guarded by an existence check, so the same file is a no-op on a fresh database and does the work on an existing one — one schema definition in the world. ALTER TABLE ... RENAME is catalog-only, so the millions of HNSW-indexed vectors are untouched. The trigger functions are recreated explicitly, because plpgsql bodies are stored as opaque text and do not follow renames: they would have compiled fine and then failed at the next INSERT. They now read the text-search config from a database setting rather than hardcoding 'swedish'. Verified: migration round-trips to a byte-identical schema across columns, indexes and triggers; re-running is a no-op; triggers repopulate search_vector with working Swedish stemming on INSERT and UPDATE; and the renamed code runs real searches against a migrated database holding 5,000 rows of production data, with plain, prefix and exclusion syntax all working. Frontend type errors went from 9 to 7 — the rename fixed two and introduced none. Not yet done, and tracked: legacy compatibility views, the shim for SQL replayed from saved snapshots, tool-name aliases, and updating docs to the new names. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	1 week ago

Author

SHA1

Message

Date

Lasse Edfast

80771ff4aa

Rename the schema and code from Swedish to English

talks -> speeches ("talks" reads as conference talks to everyone outside this
project), motions -> documents with a new doc_type column so bills, written
questions and committee reports can share the table later, and 79 columns from
anforandetext -> text, intressent_id -> person_id, valkrets -> constituency,
lydelse -> text, and so on.

_postgres/rename_map.py is the single source of truth. The migration, its rollback,
and the code rewrite are all derived from it, so they cannot drift apart. Hand-
writing a rollback is how you end up with one that fails halfway through.

Two identifiers could not be renamed mechanically and were done by reading the
queries: dok_id means the protocol document in talks but the primary key in
motions, and year stays a calendar year in speeches while becoming session_year in
documents. The latter is aliased in SQL so the JSON field stays `year` and the
frontend contract is unchanged.

Values are never translated. Bifall and Avslag stay as published; parliament.yaml
glosses them. A research tool must not silently rewrite the record.

The migration is guarded by an existence check, so the same file is a no-op on a
fresh database and does the work on an existing one — one schema definition in the
world. ALTER TABLE ... RENAME is catalog-only, so the millions of HNSW-indexed
vectors are untouched.

The trigger functions are recreated explicitly, because plpgsql bodies are stored
as opaque text and do not follow renames: they would have compiled fine and then
failed at the next INSERT. They now read the text-search config from a database
setting rather than hardcoding 'swedish'.

Verified: migration round-trips to a byte-identical schema across columns, indexes
and triggers; re-running is a no-op; triggers repopulate search_vector with working
Swedish stemming on INSERT and UPDATE; and the renamed code runs real searches
against a migrated database holding 5,000 rows of production data, with plain,
prefix and exclusion syntax all working. Frontend type errors went from 9 to 7 —
the rename fixed two and introduced none.

Not yet done, and tracked: legacy compatibility views, the shim for SQL replayed
from saved snapshots, tool-name aliases, and updating docs to the new names.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 week ago

1 Commits (main)